[Asterisk-code-review] Add initial SDP state code. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/4961 )

Change subject: Add initial SDP state code.
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4961/4/main/sdp_state.c
File main/sdp_state.c:

PS4, Line 49: struct ast_sdp_state *ast_sdp_state_alloc(struct ast_stream_topology *streams, const struct ast_sdp_options *options)
            : {
            : 	struct ast_sdp_state *sdp_state;
            : 
            : 	sdp_state = ast_calloc(1, sizeof(*sdp_state));
            : 	if (!sdp_state) {
            : 		return NULL;
            : 	}
            : 
            : 	sdp_state->options = (struct ast_sdp_options *) options;
Why are options const here? Since the state object is going to take ownership can't this just be non-const thus avoiding the cast?


-- 
To view, visit https://gerrit.asterisk.org/4961
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3757ce186f04b65e9d1883f5aace53f24e53709
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes