[Asterisk-code-review] app voicemail: vm authenticate accesses uninitialized memory (asterisk[14])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/5020 )

Change subject: app_voicemail: vm_authenticate accesses uninitialized memory
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5020/4/apps/app_voicemail.c
File apps/app_voicemail.c:

PS4, Line 11358: 	struct ast_vm_user *vmu = NULL, vmus = {{0}};
               : 	char *context = NULL;
               : 	int silentexit = 0;
               : 	struct ast_flags flags = { 0 };
               : 	signed char record_gain = 0;
               : 	int play_auto = 0;
               : 	int play_folder = 0;
               : 	int in_urgent = 0;
               : #ifdef IMAP_STORAGE
               : 	int deleted = 0;
               : #endif
               : 
               : 	/* Add the vm_state to the active list and keep it active */
               : 	memset(&vms, 0, sizeof(vms));
               : 
               : 	vms.lastmsg = -1;
               : 
               : 	memset(&vmus, 0, sizeof(vmus));
The memset can probably removed for this case now since both aren't needed.


-- 
To view, visit https://gerrit.asterisk.org/5020
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3cc0128f93d352ed9add8d5c2f0f7232c2cbe4a
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes