[Asterisk-code-review] res config sqlite3: Properly create missing columns when nec... (asterisk[13])

[Sean Bright]

Sean Bright has uploaded a new patch set (#2). ( https://gerrit.asterisk.org/4969 )

Change subject: res_config_sqlite3: Properly create missing columns when necessary
......................................................................

res_config_sqlite3: Properly create missing columns when necessary

There were two specific issues resolved here:

1) The code that iterated over the required fields
   (via ast_realtime_require) was broken for the RQ_INTEGER1 field
   type. Iteration would stop when the first RQ_INTEGER1 (0) field
   was encountered.

2) sqlite3_changes() was used to try and count the number of rows
   returned by a SELECT statement. sqlite3_changes() only counts
   affected rows, so this was always returning the value from the
   most recent data modification statement. We now separate read-only
   queries from data modification queries and count rows appropriately
   in both cases.

ASTERISK-23457 #close
Reported by: Scott Griepentrog

Change-Id: I91ed20494efc3fcfbc2a96ac7646999a49814884
---
M res/res_config_sqlite3.c
1 file changed, 157 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/69/4969/2
-- 
To view, visit https://gerrit.asterisk.org/4969
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91ed20494efc3fcfbc2a96ac7646999a49814884
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>