[Asterisk-code-review] Typo in registering transport (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Feb 16 05:38:07 CST 2017


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4968 )

Change subject: Typo in registering transport
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4968/1/res/res_pjsip_transport_websocket.c
File res/res_pjsip_transport_websocket.c:

Line 433: 	pjsip_transport_register_type(PJSIP_TRANSPORT_RELIABLE | PJSIP_TRANSPORT_SECURE, "WSS", 5060, &transport_type_wss);
This is on purpose and was changed as a result of ASTERISK-24330.

'WSS' is not a valid transport parameter. The RFC states that it should be 'WS' for both secure and insecure.


-- 
To view, visit https://gerrit.asterisk.org/4968
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a0fb1a41101a4c1e49d875a8aa87b189e7ab12
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jørgen H <asterisk.org at hovland.cx>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list