[Asterisk-code-review] Add initial SDP options. (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/4908 )

Change subject: Add initial SDP options.
......................................................................


Patch Set 6:

> (1 comment)

This is a case where I can see the benefits both ways. If you make it dynamic, then people that want to add their own SDP translator just need to come up with some name for it and that's it. With the current method, they have to add to the enum.

However, I like the current method. Frankly, I'm doubtful we'll be seeing a lot of people that are going to want to write a custom SDP translator in the first place. And then, of those that do, you'd have to narrow this down to people that don't want to contribute their work to the Asterisk project. And then, you have to narrow this down to people that have their custom module but aren't maintaining any other changes to the Asterisk core. It just seems like you're targeting a group that is likely not to exist.

-- 
To view, visit https://gerrit.asterisk.org/4908
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ede91aafed403b12a9ccdfb91a88389baa7e5d7
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No