[Asterisk-code-review] res pjsip pubsub: Correctly implement persisted subscriptions (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/4916 )

Change subject: res_pjsip_pubsub:  Correctly implement persisted subscriptions
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.asterisk.org/#/c/4916/6/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

PS6, Line 2863: 		ind->sub_tree->expiration_task = ast_sip_schedule_task(ind->sub_tree->serializer,
              : 			ind->expires * 1000, serialized_pubsub_on_refresh_timeout, name,
              : 			ao2_bump(ind->sub_tree), AST_SIP_SCHED_TASK_FIXED);
> The ind->sub_tree refs are handled unsafely.  Canceling the timer will ref 
I started with the 2 different callbacks and TASK_DATA_AO2 and couldn't get the ref counts to balance.  Definitely missing cleanups though.   I'll try again.

Oh, you missed the fact that I still had the ifdef with the XXX at the end for testing. :)


-- 
To view, visit https://gerrit.asterisk.org/4916
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c605fc1e3923f466a74db087d5ab6f90abce68e
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes