[Asterisk-code-review] res pjsip pubsub: Correctly implement persisted subscriptions (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4916 )

Change subject: res_pjsip_pubsub:  Correctly implement persisted subscriptions
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/4916/3/res/res_pjsip_exten_state.c
File res/res_pjsip_exten_state.c:

Line 358: 		ast_log(LOG_NOTICE, "Extension '%s' state subscription failed: "
Endpoint '%s' extension state...


https://gerrit.asterisk.org/#/c/4916/3/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

Line 3578: 		(unsigned long)(sub_tree ?: 0),
Oops.  I think I got this wrong.  I hadn't noticed that the format string specified %p.  I thought it was %s.  Solaris crashes when passing NULL to a %s because they don't check for NULL before dereferencing it.


Line 3625: 		ast_log(LOG_ERROR, "Possible terminate race prevented %p %d\n", sub_tree->evsub, sub_tree->state);
Still an ERROR message.


-- 
To view, visit https://gerrit.asterisk.org/4916
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c605fc1e3923f466a74db087d5ab6f90abce68e
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes