[Asterisk-code-review] res pjsip.c: Fix inconsistency between warning and action. (asterisk[13])
Anonymous Coward
asteriskteam at digium.com
Mon Feb 13 12:07:03 CST 2017
Anonymous Coward #1000019 has submitted this change and it was merged. ( https://gerrit.asterisk.org/4927 )
Change subject: res_pjsip.c: Fix inconsistency between warning and action.
......................................................................
res_pjsip.c: Fix inconsistency between warning and action.
The original return value corresponded to AST_SIP_AUTHENTICATION_CHALLENGE
but we have no authenticator registered to create the challenge.
Change-Id: I62368180d774b497411b80fbaabd0c80841f8512
---
M res/res_pjsip.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
George Joseph: Looks good to me, approved
Anonymous Coward #1000019: Verified
Joshua Colp: Looks good to me, but someone else must approve
diff --git a/res/res_pjsip.c b/res/res_pjsip.c
index 1bc8fb8..9b99058 100644
--- a/res/res_pjsip.c
+++ b/res/res_pjsip.c
@@ -2356,7 +2356,7 @@
{
if (!registered_authenticator) {
ast_log(LOG_WARNING, "No SIP authenticator registered. Assuming authentication is successful\n");
- return 0;
+ return AST_SIP_AUTHENTICATION_SUCCESS;
}
return registered_authenticator->check_authentication(endpoint, rdata, tdata);
}
--
To view, visit https://gerrit.asterisk.org/4927
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62368180d774b497411b80fbaabd0c80841f8512
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
More information about the asterisk-code-review
mailing list