[Asterisk-code-review] manager: Restore Originate failure behavior from Asterisk 11 (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4913 )

Change subject: manager: Restore Originate failure behavior from Asterisk 11
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/4913/1/include/asterisk/pbx.h
File include/asterisk/pbx.h:

PS1, Line 1133: #define AST_OUTGOING_EXT_NO_WAIT          0
              : #define AST_OUTGOING_EXT_WAIT             1
              : #define AST_OUTGOING_EXT_WAIT_GOTO_FAILED 2
Based upon how it was originally behaving in v11, you don't need two different defines.  One will do.

enum ast_pbx_outgoing_sync {
 /*! Don't wait for originated call to answer. */
 AST_OUTGOING_NO_WAIT = 0,
 /*! Wait for originated call to answer */
 AST_OUTGOING_WAIT = 1,
 /*! Wait for originated call to answer and hangup */
 AST_OUTGOING_WAIT_COMPLETE = 2,
};



In pbx.c:ast_pbx_outgoing_exten() the "&& 1 < synchronous" line needs to be changed to "&& 0 < synchronous" to restore the original v11 behavior.


PS1, Line 1150:  * \param synchronous If zero then don't wait for anything.
              :  *        If one then block until the outbound channel answers or the call fails.
              :  *        If greater than one then wait for the call to complete or if the call doesn't
              :  *        answer and failed at context exists then run a channel named OutgoingSpoolFailed
              :  *        at failed at context.
Executing failed at context originally happened if synchronous was 1 or 2 and the call failed.

Add note about using the enum ast_pbx_outgoing_sync values.


PS1, Line 1192:  * \param synchronous If zero then don't wait for anything.
              :  *        If one then block until the outbound channel answers or the call fails.
              :  *        If greater than one then wait for the call to complete.
Add note about using the enum ast_pbx_outgoing_sync values.


https://gerrit.asterisk.org/#/c/4913/1/main/manager.c
File main/manager.c:

Line 5107: 			AST_OUTGOING_EXT_WAIT_GOTO_FAILED,
This needs to remain a 1 (wait).  The problem is not with this line as I describe elsewhere.


-- 
To view, visit https://gerrit.asterisk.org/4913
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8afbd06725e99610e02adb529137d4800c05345d
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes