[Asterisk-code-review] res pjsip pubsub: Correctly implement persisted subscriptions (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4916 )

Change subject: res_pjsip_pubsub:  Correctly implement persisted subscriptions
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/4916/1/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

Line 1510: 				ast_log(LOG_ERROR, "Unable to allocate memory for initial_notify_data\n");
This error message is redundant with the generic out of memory message already logged.


PS1, Line 1522: 				/* Could not send initial subscribe NOTIFY */
              : 				pjsip_evsub_terminate(sub_tree->evsub, PJ_TRUE);
              : 				ao2_ref(sub_tree, -1);
ind is leaked here.


Line 2958: 			ast_log(LOG_ERROR, "Unable to allocate memory for initial_notify_data\n");
Redundant out of memory error


PS1, Line 2972: 			pjsip_evsub_terminate(sub_tree->evsub, PJ_TRUE);
              : 			ao2_ref(sub_tree, -1);
ind is leaked here


-- 
To view, visit https://gerrit.asterisk.org/4916
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c605fc1e3923f466a74db087d5ab6f90abce68e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes