[Asterisk-code-review] core: Cleanup some channel snapshot staging anomalies. (asterisk[13])

George Joseph asteriskteam at digium.com
Fri Feb 10 07:56:09 CST 2017


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/4909 )

Change subject: core: Cleanup some channel snapshot staging anomalies.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/4909/1/main/channel.c
File main/channel.c:

Line 823: 		/*
You might want to update the comment to highlight that all ast_channel_stage_snapshot does is set a flag so that's really why it doesn't need to be completed if the channel is going away.  I had to go look at the code to understand.


-- 
To view, visit https://gerrit.asterisk.org/4909
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefb6336893163f6447bad65568722ad5d5d8212a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list