[Asterisk-code-review] pjsip/registration/.../regcontext: Use better start trigger (testsuite[master])

[Anonymous Coward]

Anonymous Coward #1000019 has submitted this change and it was merged. ( https://gerrit.asterisk.org/4855 )

Change subject: pjsip/registration/.../regcontext:  Use better start trigger
......................................................................


pjsip/registration/.../regcontext:  Use better start trigger

The regcontext test was using the CONTACT_ADDED TEST_FRAMEWORK
event as the signal to check the sipregs context for the registered
extension but that event is actually generated BEFORE the extension
is added to the context.  Depending on system capacity, debug/on/off,
realtime, etc., the check therefore could return an empty dialplan
list.

Changed the trigger event to PeerStatus/Reachable which is only
generated after the extension add completes.  This also removes
the test's dependency on TEST_FRAMEWORK.

Change-Id: I0d4f975489cd6789b10bc1e5a384403b17b33aa1
---
M tests/channels/pjsip/registration/inbound/nominal/regcontext/test-config.yaml
1 file changed, 3 insertions(+), 6 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, approved
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, but someone else must approve



diff --git a/tests/channels/pjsip/registration/inbound/nominal/regcontext/test-config.yaml b/tests/channels/pjsip/registration/inbound/nominal/regcontext/test-config.yaml
index 525bfef..8e4b3de 100644
--- a/tests/channels/pjsip/registration/inbound/nominal/regcontext/test-config.yaml
+++ b/tests/channels/pjsip/registration/inbound/nominal/regcontext/test-config.yaml
@@ -31,13 +31,11 @@
         ami-events:
             conditions:
                 match:
-                     Event: 'TestEvent'
-                     State: 'AOR_CONTACT_ADDED'
-                     AOR: 'alice'
+                     Event: 'PeerStatus'
+                     PeerStatus: 'Reachable'
             requirements:
                 match:
-                     Contact: 'sip:alice at 127.0.0.1:5061'
-                     Expiration: '60'
+                     Peer: 'PJSIP/alice'
             count: '1'
         ami-actions:
             action:
@@ -84,7 +82,6 @@
 properties:
     minversion: '13.8.0'
     dependencies:
-        - buildoption: 'TEST_FRAMEWORK'
         - python: 'twisted'
         - python: 'starpy'
         - sipp:

-- 
To view, visit https://gerrit.asterisk.org/4855
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d4f975489cd6789b10bc1e5a384403b17b33aa1
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>