[Asterisk-code-review] res rtp asterisk: Swap byte-order when sending signed linear (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/4843 )

Change subject: res_rtp_asterisk:  Swap byte-order when sending signed linear
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4843/6/include/asterisk/codec.h
File include/asterisk/codec.h:

PS6, Line 77: 	unsigned int smooth:1;
            : 	/*! \brief Flags for the smoother */
            : 	unsigned int smoother_flags:3;
You're going to have to force the compiler to pack those into the same size as the original int or "mod" may get pushed down and break compatibility.

Do you really need to split them anyway?


-- 
To view, visit https://gerrit.asterisk.org/4843
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I868449617d1a7819578f218c8c6b2111ad84f5a9
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes