[Asterisk-code-review] channels/SIP/ami/sip notify/call id: 3PCC patch for AMI "SIP... (testsuite[master])

[Yasuhiko Kamata]

Yasuhiko Kamata has posted comments on this change. ( https://gerrit.asterisk.org/7705 )

Change subject: channels/SIP/ami/sip_notify/call_id: 3PCC patch for AMI "SIPnotify".
......................................................................


Patch Set 2:

(1 comment)

Thanks for review.

First '200 OK' is a response for NOTIFY, second is a response for initial INVITE (so variable "$2" refers the seqno of initial INVITE).

https://gerrit.asterisk.org/#/c/7705/2/tests/channels/SIP/ami/sip_notify/call_id/sipp/callee.xml
File tests/channels/SIP/ami/sip_notify/call_id/sipp/callee.xml:

https://gerrit.asterisk.org/#/c/7705/2/tests/channels/SIP/ami/sip_notify/call_id/sipp/callee.xml@61
PS2, Line 61:     <send>
> I'm unsure why we want to send '200 OK' twice in a row?  I think we probabl
First '200 OK' is a response for NOTIFY, second is a response for initial INVITE (so variable "$2" refers the seqno of initial INVITE).



-- 
To view, visit https://gerrit.asterisk.org/7705
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idccbf32ed6670a5205ee99bd7413c7fe0804efb1
Gerrit-Change-Number: 7705
Gerrit-PatchSet: 2
Gerrit-Owner: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Comment-Date: Wed, 27 Dec 2017 06:47:31 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171227/8a4376a5/attachment.html>