[Asterisk-code-review] confbridge: Handle user hangup during name recording (asterisk[master])

Sean Bright asteriskteam at digium.com
Tue Aug 29 09:28:12 CDT 2017


Sean Bright has uploaded this change for review. ( https://gerrit.asterisk.org/6323


Change subject: confbridge: Handle user hangup during name recording
......................................................................

confbridge: Handle user hangup during name recording

This prevents orphaned CBAnn channels from getting stuck in the bridge.

ASTERISK-26994 #close
Reported by: James Terhune

Change-Id: I5e43e832a9507ec3f2c59752cd900b41dab80457
---
M apps/app_confbridge.c
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/23/6323/1

diff --git a/apps/app_confbridge.c b/apps/app_confbridge.c
index b2d612d..d218d0f 100644
--- a/apps/app_confbridge.c
+++ b/apps/app_confbridge.c
@@ -2326,7 +2326,11 @@
 	if (!quiet &&
 		(ast_test_flag(&user.u_profile, USER_OPT_ANNOUNCE_JOIN_LEAVE) ||
 		(ast_test_flag(&user.u_profile, USER_OPT_ANNOUNCE_JOIN_LEAVE_REVIEW)))) {
-		conf_rec_name(&user, args.conf_name);
+		if (conf_rec_name(&user, args.conf_name)) {
+			pbx_builtin_setvar_helper(chan, "CONFBRIDGE_RESULT", "FAILED");
+			res = -1; /* Hangup during name recording */
+			goto confbridge_cleanup;
+		}
 	}
 
 	/* menu name */

-- 
To view, visit https://gerrit.asterisk.org/6323
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e43e832a9507ec3f2c59752cd900b41dab80457
Gerrit-Change-Number: 6323
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170829/373e753d/attachment-0001.html>


More information about the asterisk-code-review mailing list