[Asterisk-code-review] app controlplayback: Don't fail on filenames containing colons (asterisk[13])

Sean Bright asteriskteam at digium.com
Thu Aug 24 13:32:20 CDT 2017


Sean Bright has uploaded this change for review. ( https://gerrit.asterisk.org/6299


Change subject: app_controlplayback: Don't fail on filenames containing colons
......................................................................

app_controlplayback: Don't fail on filenames containing colons

There is some - I assume legacy - code that allows a filename passed to
ast_control_streamfile() to be suffixed with ':end' in order to seek
from the end of file, rather than beginning.

Change the behavior such that if we find a colon but we don't find
':end' we continue as if we never found the colon at all.

ASTERISK-23608 #close
Reported by: Jonathan White

Change-Id: I9d08db97aaffaeb9a9bb176420332878814f7286
---
M main/app.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/99/6299/1

diff --git a/main/app.c b/main/app.c
index 85dc87d..8ea6f82 100644
--- a/main/app.c
+++ b/main/app.c
@@ -1113,6 +1113,8 @@
 		if (!strcasecmp(end, ":end")) {
 			*end = '\0';
 			end++;
+		} else {
+			end = NULL;
 		}
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/6299
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d08db97aaffaeb9a9bb176420332878814f7286
Gerrit-Change-Number: 6299
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170824/958fc018/attachment.html>


More information about the asterisk-code-review mailing list