[Asterisk-code-review] res xmpp: Google OAuth 2.0 protocol support for XMPP / Motif (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6158 )

Change subject: res_xmpp: Google OAuth 2.0 protocol support for XMPP / Motif
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/6158/3/res/res_xmpp.c
File res/res_xmpp.c:

https://gerrit.asterisk.org/#/c/6158/3/res/res_xmpp.c@778
PS3, Line 778: ==
Shouldn't this be '&&'?


https://gerrit.asterisk.org/#/c/6158/3/res/res_xmpp.c@779
PS3, Line 779: either
s/either/or/


https://gerrit.asterisk.org/#/c/6158/3/res/res_xmpp.c@3904
PS3, Line 3904: {
Should be on the following line


https://gerrit.asterisk.org/#/c/6158/3/res/res_xmpp.c@3905
PS3, Line 3905: 	char cmd[4096];
              : 	char cBuf[4096];
I'd use ast_calloc or ast_asprintf to allocate these.  8K is a little big for the stack.



-- 
To view, visit https://gerrit.asterisk.org/6158
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I07f7052a502457ab55010a4d3686653b60f4c8db
Gerrit-Change-Number: 6158
Gerrit-PatchSet: 3
Gerrit-Owner: Andrey <andr06 at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 07 Aug 2017 11:25:23 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170807/041ee7cf/attachment.html>