[Asterisk-code-review] vector: defaults and indexes (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/5533 )

Change subject: vector: defaults and indexes
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5533/1/include/asterisk/vector.h
File include/asterisk/vector.h:

Line 258: 	typeof(size) __size = size ? size : AST_VECTOR_SIZE(vec);	\
Be sure to place parentheses around "size" each time you access it in the macro.

It may be a good idea to protect against side-effects from accesses of "size" as well, but it's unlikely that anyone would put something side-effect-causing as the "size" parameter here.


-- 
To view, visit https://gerrit.asterisk.org/5533
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf4b51b2540eda57cb43f67aa59cf1d96cdbcaa5
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes