[Asterisk-code-review] sdp: Add support for T.38 (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5496 )

Change subject: sdp: Add support for T.38
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/5496/2/main/sdp_state.c
File main/sdp_state.c:

PS2, Line 400: 	type = ast_stream_get_type(ast_stream_topology_get_stream(sdp_state->proposed_capabilities->topology,
             : 		stream_index));
             : 	ast_assert(type == AST_MEDIA_TYPE_AUDIO || type == AST_MEDIA_TYPE_VIDEO);
I was wanting to avoid calling ast_stream_get_type() when assertions aren't enabled.  I think we'll get a set but not used warning when assertions are disabled.


PS2, Line 420: 	type = ast_stream_get_type(ast_stream_topology_get_stream(sdp_state->proposed_capabilities->topology,
             : 		stream_index));
             : 	ast_assert(type == AST_MEDIA_TYPE_IMAGE);
I was wanting to avoid calling ast_stream_get_type() when assertions aren't enabled.  I think we'll get a set but not used warning when assertions are disabled.


-- 
To view, visit https://gerrit.asterisk.org/5496
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If28956762ccb8ead562ac6c03d162d3d6014f2c7
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes