[Asterisk-code-review] SDP: Ensure SDPs "merge" properly. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5415 )

Change subject: SDP: Ensure SDPs "merge" properly.
......................................................................


Patch Set 7: Code-Review-1

(6 comments)

https://gerrit.asterisk.org/#/c/5415/7/include/asterisk/sdp_state.h
File include/asterisk/sdp_state.h:

PS7, Line 238: /*!
             :  * \since 15.0.0
             :  * \brief Generate a local SDP based on the current SDP state
             :  *
             :  * \param sdp_state
             :  * \retval NULL Failed to create an SDP
             :  * \retval non-NULL The newly-created SDP
             :  */
             : struct ast_sdp *ast_sdp_create_from_state(const struct ast_sdp_state *sdp_state);
             : 
Delete this change as this function does not exist.  The corresponding function is static anyway.


https://gerrit.asterisk.org/#/c/5415/7/main/sdp.c
File main/sdp.c:

Line 660: 	if (sscanf(attr->value, "%30d %ms", &ignore, &param) != 2) {
%ms in incompatible with MALLOC_DEBUG


https://gerrit.asterisk.org/#/c/5415/7/main/sdp_state.c
File main/sdp_state.c:

Line 238:  * done so that the negotiated capabilities can be falledn back on if the proposed
s/falledn/fallen/


PS7, Line 298: 	ast_sdp_translator_free(sdp_state->translator);
             : }
Need to free sdp_state too since this is not an ao2 object.

ast_free(sdp_state);


Line 1120: 	struct ast_rtp_instance *rtp = NULL;
The rtp variable is not used.


Line 1171: 		ao2_cleanup(rtp);
The rtp variable is not used.


-- 
To view, visit https://gerrit.asterisk.org/5415
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5938c2be3c6f0a003aa88a39a59e0880f8b2df3d
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes