[Asterisk-code-review] core: Use eventfd for alert pipes on Linux when possible (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5497 )

Change subject: core: Use eventfd for alert pipes on Linux when possible
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/5497/3/include/asterisk/alertpipe.h
File include/asterisk/alertpipe.h:

PS3, Line 4:  * Copyright (C) 2012, Digium, Inc.
           :  *
           :  * Mark Spencer <markster at digium.com>
           :  *
I think you're entitled to put your own copyright here!


Line 33:  *
Put a \since tag here to indicate the first version the new apis are available.  You can use 13.16.0 for all branches.

Same for all following declarations.


Line 85: static inline void ast_alertpipe_clear(int filedes[2])
Why not just #define?

If you want to stick with inline, use AST_INLINE_API.


https://gerrit.asterisk.org/#/c/5497/3/main/alertpipe.c
File main/alertpipe.c:

PS3, Line 4:  * Copyright (C) 2012, Digium, Inc.
           :  *
           :  * Mark Spencer <markster at digium.com>
           :  *
Copyright again.


-- 
To view, visit https://gerrit.asterisk.org/5497
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff0fb1573e7f7a187d5211ddc60aa8f3da3edb1d
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes