[Asterisk-code-review] chan sip: Trigger reinvite if the SDP answer is included in ... (asterisk[master])

[Jean Aunis - Prescom]

Jean Aunis - Prescom has posted comments on this change. ( https://gerrit.asterisk.org/5509 )

Change subject: chan_sip: Trigger reinvite if the SDP answer is included in the SIP ACK
......................................................................


Patch Set 1:

I have some doubts here :

- firstly, I am modifying some code which was previously written to fix the exact same issue  (see commit 70ca2e51a). So I guess it worked some time ago, but why did it stop working ?

- secondly, the other places in chan_sip where a re-INVITE is triggered contain a condition like this :
if (p->t38.state == T38_DISABLED || p->t38.state == T38_REJECTED)
So, should we use this condition instead of testing if direct media is enabled ?

-- 
To view, visit https://gerrit.asterisk.org/5509
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3644d2025f20e086ea9f8f62b486172c52b5b2e6
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Reviewer: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Reviewer: Jenkins2
Gerrit-HasComments: No