[Asterisk-code-review] SDP: Ensure SDPs "merge" properly. (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5415 )

Change subject: SDP: Ensure SDPs "merge" properly.
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.asterisk.org/#/c/5415/6/main/sdp.c
File main/sdp.c:

Line 582: 	if (sscanf(value_copy, "%30d %s", &payload, encoding_name) != 2) {
Is encoding_name guaranteed to always be 63 characters or less? If not you should use %63s or %ma here.


https://gerrit.asterisk.org/#/c/5415/6/main/sdp_state.c
File main/sdp_state.c:

Line 668: 			&port, cand_type, relay_address, &relay_port) < 7) {
Should this be 8 instead of 7? You're trying to match/assign 9 fields.


-- 
To view, visit https://gerrit.asterisk.org/5415
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5938c2be3c6f0a003aa88a39a59e0880f8b2df3d
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes