[Asterisk-code-review] testsuite: test fast T.38 reinvite behaviour (testsuite[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5410 )

Change subject: testsuite: test fast T.38 reinvite behaviour
......................................................................


Patch Set 2: Code-Review-2

> I don't think there is a reliable way to actually test for this.
 > For example I ran this test on my system a few times and it worked
 > without the fix. The SIP traffic itself doesn't introduce the race
 > condition, it's merely how fast things can get added to the bridge
 > before the re-invite is received and handled in PJSIP land.

On my system, the test always passes on master, with or without the code patch.  On 13, it always fails with a 488 without the patch, but with the patch, it seems to be a 50/50 pass/fail if i run it 10 times in a row.

-- 
To view, visit https://gerrit.asterisk.org/5410
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb2d124958dd2b273ca91a771b1e667992e2c103
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Torrey Searle <tsearle at gmail.com>
Gerrit-HasComments: No