[Asterisk-code-review] SDP: Ensure SDPs "merge" properly. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5415 )

Change subject: SDP: Ensure SDPs "merge" properly.
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/5415/5/include/asterisk/sdp.h
File include/asterisk/sdp.h:

PS5, Line 568:  * \param sdp The SDP in which to search
             :  * \param attr_name The name of the attribute to search for
             :  * \param payload Optional payload number to search for. If irrelevant, set to -1
             :  * \retval NULL Could not find the given attribute
             :  * \retval Non-NULL The attribute to find
Can we be consistent on formatting?

 * \param
 * \param
 * 
 * \retval
 * \retval
 * 
 * \since


https://gerrit.asterisk.org/#/c/5415/5/main/sdp.c
File main/sdp.c:

PS5, Line 543: *!
             :  * \brief Convert the string representation of media to its AST_MEDIA_* type
             :  */
             : static enum ast_media_type media_type_from_str(const char *media_type_str)
             : {
             : 	if (!strcasecmp(media_type_str, "audio")) {
             : 		return AST_MEDIA_TYPE_AUDIO;
             : 	} else if (!strcasecmp(media_type_str, "video")) {
             : 		return AST_MEDIA_TYPE_VIDEO;
             : 	} else if (!strcasecmp(media_type_str, "image")) {
             : 		return AST_MEDIA_TYPE_IMAGE;
             : 	} else if (!strcasecmp(media_type_str, "text")) {
             : 		return AST_MEDIA_TYPE_TEXT;
             : 	} else {
             : 		return AST_MEDIA_TYPE_UNKNOWN;
             : 	}
             : }
Let's move this to codec.c along side ast_codec_media_type2str and make it public.  It can actually be used there in show_codecs.


https://gerrit.asterisk.org/#/c/5415/5/main/sdp_options.c
File main/sdp_options.c:

Line 107: 
Extra newline


-- 
To view, visit https://gerrit.asterisk.org/5415
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5938c2be3c6f0a003aa88a39a59e0880f8b2df3d
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes