[Asterisk-code-review] res pjsip sdp rtp: No rtpmap for static RTP payload IDs in SDP. (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5431 )

Change subject: res_pjsip_sdp_rtp: No rtpmap for static RTP payload IDs in SDP.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5431/1/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

Line 460: 	if (35 > rtp_code && pjsip_use_compact_form) {
> Ahh. So your actual comment was a question: ‘Why does the range ends/starts
> Ahh. So your actual comment was a question: ‘Why does the range
 > ends/starts exactly at 35? Please, document that (for example with
 > an inline comment and/or a DEFINE into the code).’ That would have
 > explained where your are, what you are looking for, and two
 > examples how to solve that.


Why does the range ends/starts exactly at 35? Please, document that (for example with a #define).

 > 
 > OK, before I make up a name, just the explanation:
 > 34 is the last payload type which was assigned statically
 > <http://www.iana.org/assignments/rtp-parameters>. There is no
 > higher payload type which has a static ID. The idea of this change
 > is to give no rtpmap for those payload types which are static.
 > 
 > Was that sufficient? Then, I would add that as inline comment.

Now I understand. Something like this in rtp_engine.h would make me happy:

    #define AST_RTP_PT_MAX_STATIC 34


-- 
To view, visit https://gerrit.asterisk.org/5431
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa556ab4c8325cd34c334387ab2847fab07b1689
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes