[Asterisk-code-review] res pjsip sdp rtp: No rtpmap for static RTP payload IDs in SDP. (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5431 )

Change subject: res_pjsip_sdp_rtp: No rtpmap for static RTP payload IDs in SDP.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5431/1/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

Line 460: 	if (35 > rtp_code && pjsip_use_compact_form) {
> Mhm. Any specific idea? I am not aware of a DEFINE for this, yet. Do you wa
> Mhm. Any specific idea? I am not aware of a DEFINE for this, yet.
 > Do you want me to create a local variable with some name (like an
 > inline comment) or do you want me to change this Asterisk wide
 > (chan_sip and rtp_engine) to the same symbol?

I'm not particularly concerned with chan_sip, but you could #define something in rtp_engine.h to give it some semantic meaning (I don't actually know what the '35' means here, which is why I posted the original comment).


-- 
To view, visit https://gerrit.asterisk.org/5431
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa556ab4c8325cd34c334387ab2847fab07b1689
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes