[Asterisk-code-review] main/channel: Ensure successful T.38 negotation (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5409 )

Change subject: main/channel:  Ensure successful T.38 negotation
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5409/2/main/channel.c
File main/channel.c:

PS2, Line 6577: 	if (ast_channel_get_t38_state(from) == T38_STATE_NEGOTIATING && ast_channel_get_t38_state(to) == T38_STATE_UNKNOWN) {
              : 		struct ast_control_t38_parameters parameters = { .request_response = AST_T38_REQUEST_PARMS, };
              : 		ast_debug(3, "Sending T.38 param renegotiation %s.\n", ast_channel_name(from));
              : 		ast_indicate_data(from, AST_CONTROL_T38_PARAMETERS, &parameters, sizeof(parameters));
              : 	}
I don't think this is the right location for this. The purpose of this function is to ensure that the media formats are compatible between two channels, putting T.38 logic in here overloads and changes that.

I think this it makes more sense for this to be somewhere in the bridging system. Just like it has to ensure connected line updates occur it should also ensure that the T.38 negotiation occurs as expected.


-- 
To view, visit https://gerrit.asterisk.org/5409
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If334125ee61ed63550d242fc9efe7987e37e1d94
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes