[Asterisk-code-review] pjproject bundled: Add 3 upstream patches (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5406 )

Change subject: pjproject_bundled: Add 3 upstream patches
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Neither of our uses of pjsip_tsx_layer_find_tsx() in pjsip_distributor.c would cause a deadlock.

https://gerrit.asterisk.org/#/c/5406/3/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:

Line 123: 	if (tsx->last_tx) {
We need to get the tsx lock before we try to use tsx->last_tx.  We do not want another thread transmitting a message and updating the tsx->last_tx on us!

pj_grp_lock_acquire(tsx->grp_lock)
if (tsx->last_tx) {
}
pj_grp_lock_release(tsx->grp_lock)
pj_grp_lock_dec_ref(tsx->grp_lock)

Besides, the deadlock that created the ..._tsx2() function involved three locks internal to pjproject that are not involved in our code using the original function here.


-- 
To view, visit https://gerrit.asterisk.org/5406
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I268fb3cf71a3bb24283ff0d24bd8b03239d81256
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes