[Asterisk-code-review] pjproject bundled: Add 3 upstream patches (asterisk[13])
George Joseph
asteriskteam at digium.com
Tue Apr 4 17:34:16 CDT 2017
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5406 )
Change subject: pjproject_bundled: Add 3 upstream patches
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.asterisk.org/#/c/5406/1/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:
PS1, Line 136: #ifdef HAVE_PJ_TRANSACTION_GRP_LOCK
: pj_grp_lock_release(tsx->grp_lock);
: #else
: pj_mutex_unlock(tsx->mutex);
: #endif
> To use the new tsx2 you need to dec_ref instead of unlocking.
> The other thing. Are we actually susceptable to the deadlock? I
> think we cannot dereference the tsx->last_tx without holding the
> lock anyway.
We may not be but it's cheap insurance.
--
To view, visit https://gerrit.asterisk.org/5406
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I268fb3cf71a3bb24283ff0d24bd8b03239d81256
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list