[Asterisk-code-review] core: Improve/simplify handling of required headers. (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/5375 )

Change subject: core: Improve/simplify handling of required headers.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Looks mostly good to me.  Just one minor nit I noticed.

https://gerrit.asterisk.org/#/c/5375/2/configure.ac
File configure.ac:

Line 618: AC_CHECK_HEADERS([arpa/inet.h libintl.h locale.h malloc.h netdb.h stddef.h strings.h sys/event.h utime.h])
I think that you need to move locale.h up to the unconditionally included block due to its use in main/ast_expr2f.c


-- 
To view, visit https://gerrit.asterisk.org/5375
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie67d0185ca71fbfb81c9bdfaebe46a49e3c56dc5
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes