[Asterisk-code-review] core: Remove ABI effects of LOW MEMORY. (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Wed Sep 28 16:16:07 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: core: Remove ABI effects of LOW_MEMORY.
......................................................................


Patch Set 2:

I would prefer that all this new conditional stuff be
#if defined(LOW_MEMORY)
or
#if !defined(LOW_MEMORY)

and the closing #endif have an end comment of /* LOW_MEMORY */ or similar.  The end comment is more needed for the larger conditional blocks.

Other than the formatting this looks fine.

-- 
To view, visit https://gerrit.asterisk.org/3960
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24b78ac9493ab933b11087a8b6794f3c96d4872d
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list