[Asterisk-code-review] chan sip: Address runaway when realtime peers subscribe to ... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: chan_sip:  Address runaway when realtime peers subscribe to mailboxes
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/3962/4/channels/chan_sip.c
File channels/chan_sip.c:

Line 31029: 	/* We preserve the original value of v_head to make analyzing backtraces easier */
This will do as you intend if DONT_OPTIMIZE is enabled, otherwise I think it will cause v_head to be optimized out as soon as v is set.  This is an improvement though, the backtrace would tell us that v_head is unknown instead of falsely claiming it is NULL.


-- 
To view, visit https://gerrit.asterisk.org/3962
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07519ef7f092629e1e844f855abd279d6475cdd0
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes