[Asterisk-code-review] res odbc: Make pooling option deprecation notice more useful. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Wed Sep 21 11:04:19 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: res_odbc: Make pooling option deprecation notice more useful.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3951/1/res/res_odbc.c
File res/res_odbc.c:

Line 526: 					ast_log(LOG_WARNING, "The 'pooling', 'shared_connections', 'limit', and 'idlecheck' options are deprecated. Please consider using the max_connections option as documented in the sample res_odbc.conf for connection pooling.\n");
How about this shorter message:
The 'pooling', 'shared_connections', 'limit', and 'idlecheck' options were replaced by 'max_connections'.  See res_odbc.conf.sample.


-- 
To view, visit https://gerrit.asterisk.org/3951
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ca9cdfdcd75aec170a7db9d5ff69a4cd25b7c10
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list