[Asterisk-code-review] asterisk.c: Non-root users also get the astcanary after core... (asterisk[11])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: asterisk.c: Non-root users also get the astcanary after core restart.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3923/1/main/asterisk.c
File main/asterisk.c:

Line 4107: 	if (ast_opt_high_priority) {
Can we check getpriority and set or unset AST_OPT_FLAG_HIGH_PRIORITY as appropriate before this?

Situations I'm thinking of:
* Startup with non-root user when highpriority=no but 'Nice' set to high priority by systemd unit file.
* Restart with non-root user when highpriority no longer enabled but was enabled for initial startup by root user (SCHED_RR set).
* Initial startup as non-root user when highpriority=yes but SCHED_RR could not be enabled.


-- 
To view, visit https://gerrit.asterisk.org/3923
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb49f26491a0717084ad46ed96b0bea5f627a55
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes