[Asterisk-code-review] rtp engine: Allow more than 32 dynamic payload types. (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change.

Change subject: rtp_engine: Allow more than 32 dynamic payload types.
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3680/5/main/rtp_engine.c
File main/rtp_engine.c:

Line 2704: 	if (0 < cfg) {
I hate that ast_config_load2 overloads the return values here.  I don't know how often you may get a legitimate negative pointer, but I'd rather check explicitly for the different return values from ast_config_load2() here instead of assuming all negative values are wrong.


-- 
To view, visit https://gerrit.asterisk.org/3680
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc96ab764bc30098a178b841cbf7146f9d64964
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes