[Asterisk-code-review] rtp: Only accept the first payload for a format in SDP. (asterisk[14])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: rtp: Only accept the first payload for a format in SDP.
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.asterisk.org/#/c/3894/4/main/rtp_engine.c
File main/rtp_engine.c:

PS4, Line 775: 		if (!current || current == to_match) {
             : 			continue;
             : 		}
> The code here needs to be:
Ok change to:
if (!current) {
   continue;
}
if (current == to_match) {
   /* The exact object is already in the mapping. */
   return 1;
}


PS4, Line 782: 			} else if (current->payload == to_match->payload) {
             : 				return 0;
> This check stops the search too soon.  What if we were trying to add/update
Ok.  I see that this doesn't need to be changed.


-- 
To view, visit https://gerrit.asterisk.org/3894
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8150860a3518cab36d00b1fab50f9352b64e60
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes