[Asterisk-code-review] vector: Prevent NULL argument to memcpy. (asterisk[13])

Corey Farrell asteriskteam at digium.com
Sun Oct 30 13:57:55 CDT 2016


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/4234 )

Change subject: vector: Prevent NULL argument to memcpy.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/4234/1/include/asterisk/vector.h
File include/asterisk/vector.h:

Line 168: 	int res = 0;								\
> maybe also add check to vec? like "if (vec)"?
No, none of the vector macro's accept NULL for vec.

In almost all cases the vector itself is either static or part of another structure.


-- 
To view, visit https://gerrit.asterisk.org/4234
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988a476bb5fcfcbd3f6d6c6b3e7769e4f9629b71
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list