[Asterisk-code-review] ARI: Detect duplicate channel IDs (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/4150 )

Change subject: ARI: Detect duplicate channel IDs
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/4150/2/main/channel.c
File main/channel.c:

Line 779: 	conflict = ast_channel_get_by_name(uniqueid);
> Does this result in recursive locking of channels?
Yes. ast_channel_get_by_name() will lock the channels container when performing its search, and there is currently not a way to pass the OBJ_NOLOCK flag to it.


-- 
To view, visit https://gerrit.asterisk.org/4150
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibba7ae68842dab6df0c2e9c45559208bc89d3d06
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes