[Asterisk-code-review] res rtp asterisk: Add blackice option (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: res_rtp_asterisk: Add blackice option
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4023/5/configs/samples/rtp.conf.sample
File configs/samples/rtp.conf.sample:

Line 72: ; blackice =
Slight nitpick, but I rather see this option named 'ice_blacklist'. That way the meaning is implied by the name itself. Also, if someone is searching for the option, or blacklist options in Asterisk they would probably search for the word 'blacklist'.


-- 
To view, visit https://gerrit.asterisk.org/4023
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibee88f80d7693874fda1cceaef94a03bd86012c9
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Michael Walton <mike at farsouthnet.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes