[Asterisk-code-review] vector: After remove element recheck index (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: vector: After remove element recheck index
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4067/3/include/asterisk/vector.h
File include/asterisk/vector.h:

Line 370: 	for (idx = ((vec)->current - 1); idx >= 0; --idx) {		\
> Not a huge deal (just less optimized), but wouldn't this result in elements
Is it valid to check (idx >= 0) when idx is size_t (unsigned)?  If it's impossible for size_t to be negative it seems like this would cause an infinite loop.


-- 
To view, visit https://gerrit.asterisk.org/4067
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib947fa94dc91dcd9341f357f1084782c64434eb7
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes