[Asterisk-code-review] raidus cdr,cel: Fix old memleak in unload (asterisk[master])

[Badalian Vyacheslav]

Badalian Vyacheslav has posted comments on this change.

Change subject: raidus cdr,cel: Fix old memleak in unload
......................................................................


Patch Set 2:

(1 comment)

since "rc_openlog" essentially calls the system "openlog" which is a function of the syslog, is a constant for him to propose to define globally. Other modules can also calls "openlog".

https://gerrit.asterisk.org/#/c/4059/1/cdr/cdr_radius.c
File cdr/cdr_radius.c:

PS1, Line 271: 
             : 
             : 
             : 
> Why was this here in the first place? What crash is it referring to, and do
Few do not know the behavior of the discharge module. You'll permanently remove the resource together with static? If so, is it possible to make static in asterisk.h?


-- 
To view, visit https://gerrit.asterisk.org/4059
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic17c38de67583e971d78fe18807d1a9faf8f0afd
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes