[Asterisk-code-review] OpenSSL 1.1.0 support (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/3102 )

Change subject: OpenSSL 1.1.0 support
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3102/6/main/iostream.c
File main/iostream.c:

Line 468: 				ERR_remove_state(0);
Looks like we've lost the fix from [1].  From what I can tell we should be using ERR_remove_thread_state(NULL) between 1.0.0 and 1.1.0.  This conditional code was removed by [2] when code was moved from tcptls.c to iostream.c.  Should it should be re-added?

[1] https://gerrit.asterisk.org/#/c/365/2/main/tcptls.c
[2] https://gerrit.asterisk.org/2932


-- 
To view, visit https://gerrit.asterisk.org/3102
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e29d477d486ca29b6aae0dc2f5dff960c1cb82b
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-HasComments: Yes