[Asterisk-code-review] Revert "Revert "channel: Use frame deferral API for safe sle... (asterisk[master])

[George Joseph]

Hello Mark Michelson, Anonymous Coward #1000019, Joshua Colp,

I'd like you to do a code review.  Please visit

    https://gerrit.asterisk.org/4416

to review the following change.


Change subject: Revert "Revert "channel: Use frame deferral API for safe sleep.""
......................................................................

Revert "Revert "channel: Use frame deferral API for safe sleep.""

This reverts commit e5365dada5052b87275c048f6e29ac7d5e2b2415.

Change-Id: Icc40cf0c7687454760762912dd29e4ae79e8e9ee
---
M main/channel.c
1 file changed, 6 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/16/4416/1

diff --git a/main/channel.c b/main/channel.c
index b30bb1d..872661c 100644
--- a/main/channel.c
+++ b/main/channel.c
@@ -1544,19 +1544,18 @@
 	int res = 0;
 	struct timeval start;
 	int ms;
-	AST_LIST_HEAD_NOLOCK(, ast_frame) deferred_frames;
-
-	AST_LIST_HEAD_INIT_NOLOCK(&deferred_frames);
 
 	/* If no other generator is present, start silencegen while waiting */
 	if (ast_opt_transmit_silence && !ast_channel_generatordata(chan)) {
 		silgen = ast_channel_start_silence_generator(chan);
 	}
 
+	ast_channel_lock(chan);
+	ast_channel_start_defer_frames(chan);
+	ast_channel_unlock(chan);
+
 	start = ast_tvnow();
 	while ((ms = ast_remaining_ms(start, timeout_ms))) {
-		struct ast_frame *dup_f = NULL;
-
 		if (cond && ((*cond)(data) == 0)) {
 			break;
 		}
@@ -1571,18 +1570,7 @@
 				res = -1;
 				break;
 			}
-
-			if (!ast_is_deferrable_frame(f)) {
-				ast_frfree(f);
-				continue;
-			}
-
-			if ((dup_f = ast_frisolate(f))) {
-				if (dup_f != f) {
-					ast_frfree(f);
-				}
-				AST_LIST_INSERT_HEAD(&deferred_frames, dup_f, frame_list);
-			}
+			ast_frfree(f);
 		}
 	}
 
@@ -1591,17 +1579,8 @@
 		ast_channel_stop_silence_generator(chan, silgen);
 	}
 
-	/* We need to free all the deferred frames, but we only need to
-	 * queue the deferred frames if there was no error and no
-	 * hangup was received
-	 */
 	ast_channel_lock(chan);
-	while ((f = AST_LIST_REMOVE_HEAD(&deferred_frames, frame_list))) {
-		if (!res) {
-			ast_queue_frame_head(chan, f);
-		}
-		ast_frfree(f);
-	}
+	ast_channel_stop_defer_frames(chan);
 	ast_channel_unlock(chan);
 
 	return res;

-- 
To view, visit https://gerrit.asterisk.org/4416
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc40cf0c7687454760762912dd29e4ae79e8e9ee
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>