[Asterisk-code-review] asterisk.py: fix twisted.internet.utils.getProcessOutputAndV... (testsuite[master])

Anonymous Coward asteriskteam at digium.com
Mon Nov 14 07:24:39 CST 2016


Anonymous Coward #1000019 has submitted this change and it was merged. ( https://gerrit.asterisk.org/4364 )

Change subject: asterisk.py: fix twisted.internet.utils.getProcessOutputAndValue use
......................................................................


asterisk.py: fix twisted.internet.utils.getProcessOutputAndValue use

According to documentation[1] the 'args' first string should *NOT* be
the executable's name.

[1] http://twistedmatrix.com/documents/16.5.0/api/twisted.internet.utils.html

Change-Id: Ic05b398a73e77a1e88f1fbef6ddb71024b704d4b
---
M lib/python/asterisk/asterisk.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  George Joseph: Looks good to me, approved
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, but someone else must approve



diff --git a/lib/python/asterisk/asterisk.py b/lib/python/asterisk/asterisk.py
index b98f2ce..bfde74f 100755
--- a/lib/python/asterisk/asterisk.py
+++ b/lib/python/asterisk/asterisk.py
@@ -196,7 +196,7 @@
 
         self._deferred = defer.Deferred()
         deferred = utils.getProcessOutputAndValue(self._cmd[0],
-                                                  self._cmd,
+                                                  self._cmd[1:],
                                                   env=os.environ)
         deferred.addCallbacks(callback=__cli_output_callback,
                               errback=__cli_error_callback,)

-- 
To view, visit https://gerrit.asterisk.org/4364
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic05b398a73e77a1e88f1fbef6ddb71024b704d4b
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Timo Teräs <timo.teras at iki.fi>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list