[Asterisk-code-review] app queue: new variable set when abandoned (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4323 )

Change subject: app_queue: new variable set when abandoned
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

> I understand for the others a test suit, but this is just adding a
 > variable is the test suit really needed?

A test shouldn't be needed for this since it is just setting a channel variable.  However, this new channel variable needs to be documented in the appropriate place of the XML comment near the beginning of the file.

https://gerrit.asterisk.org/#/c/4323/1/apps/app_queue.c
File apps/app_queue.c:

Line 4596: 	pbx_builtin_setvar_helper(qe->chan, "ABANDONED", "TRUE");
Please add a blank line after RAII_VAR to separate variable declarations from code.


-- 
To view, visit https://gerrit.asterisk.org/4323
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4729af9bff4eba436d8a776afd3374065d0036d3
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sebastian Gutierrez <scgm11 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sebastian Gutierrez <scgm11 at gmail.com>
Gerrit-HasComments: Yes