[Asterisk-code-review] ari/resource channels: Add 'formats' to channel create/orig... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: ari/resource_channels:  Add 'formats' to channel create/originate
......................................................................


Patch Set 1: Code-Review-1

(6 comments)

https://gerrit.asterisk.org/#/c/2917/1/CHANGES
File CHANGES:

Line 71:  
Redness


Line 79:  
Ditto


https://gerrit.asterisk.org/#/c/2917/1/include/asterisk/codec.h
File include/asterisk/codec.h:

Line 80: 	/*! \brief The format name for this codec */
The default cached format name for this codec


https://gerrit.asterisk.org/#/c/2917/1/main/codec.c
File main/codec.c:

Line 171: 			S_OR(codec->format_name, "no format"),
no cached format


https://gerrit.asterisk.org/#/c/2917/1/main/codec_builtin.c
File main/codec_builtin.c:

Line 777: 		codec.format_name = (codec).name; \
Should these override if something else has already cached a format for the same codec?


https://gerrit.asterisk.org/#/c/2917/1/rest-api/api-docs/channels.json
File rest-api/api-docs/channels.json:

Line 132:             {
Is the indentation right for these two?


-- 
To view, visit https://gerrit.asterisk.org/2917
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I091b23ecd41c1b4128d85028209772ee139f604b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes