[Asterisk-code-review] ARI: Re-implement the ARI dial command, allowing for early b... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: ARI: Re-implement the ARI dial command, allowing for early bridging.
......................................................................


Patch Set 8: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2790/8/res/ari/resource_channels.c
File res/ari/resource_channels.c:

Line 1630: static char *restore_dialstring(struct ast_channel *chan)
Why not group this function with save_dialstring()?


Line 1682: 	dialstring = restore_dialstring(callee);
You probably want to fail the dial if dialstring comes back as NULL.  Also there is no guarantee that dialstring will remain valid when the channel is unlocked.  It is unlikely that anything will destroy the dialstring datastore but...


-- 
To view, visit https://gerrit.asterisk.org/2790
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7750359ddf45fcd45eaec749c5b3822de4a8ddbb
Gerrit-PatchSet: 8
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes