[Asterisk-code-review] core/manager: Add uptime field to FullyBooted (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: core/manager: Add uptime field to FullyBooted
......................................................................


Patch Set 2: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/#/c/2904/2//COMMIT_MSG
Commit Message:

Line 11: ASTERISK-26058
Since this closes the issue it should have a #close tag


https://gerrit.asterisk.org/#/c/2904/2/main/asterisk.c
File main/asterisk.c:

PS2, Line 1026: 			"Uptime", "0",
              : 			"LastReload", "0");
This is now inconsistent with the AMI event, and also lies. I think both should reflect reality if it's being added.


https://gerrit.asterisk.org/#/c/2904/2/main/manager.c
File main/manager.c:

Line 4164: 		if(ast_startuptime.tv_sec){
Spaces.

if (ast_startuptime.tv_sec) {


Line 4168: 		if(ast_startuptime.tv_sec){
Same here.


PS2, Line 4174: 			"Uptime: %ld\r\n"
              : 			"LastReload: %ld\r\n"
This needs to be documented in the manager event XML at the top of asterisk.c


-- 
To view, visit https://gerrit.asterisk.org/2904
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I909b330801c0990d78df9b272ab0adc95aecb15e
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes