[Asterisk-code-review] ARI: Add the ability to download the media associated with a... (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: ARI: Add the ability to download the media associated with a stored recording
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2876/1/res/res_ari.c
File res/res_ari.c:

PS1, Line 1012: 	ast_http_send(ser, method, response.response_code,
              : 		      response.response_text, response.headers, response_body,
              : 		      response.fd, 0);
Looks like it might be possible for the file descriptor to be -1 here. This subsequently will call 'lseek' within the 'ast_http_send' function to be called with a negative file descriptor. Could this potentially cause a problem?


-- 
To view, visit https://gerrit.asterisk.org/2876
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49ec5c4afdec30bb665d9c977ab423b5387e0181
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes